Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: filter_wasm_go: Upgrade to support Go 1.22.5 and TinyGo 0.32 #9105

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

opencmit2
Copy link
Contributor

@opencmit2 opencmit2 commented Jul 18, 2024

examples: filter_wasm_go: Upgrade to support Go 1.22.5 and TinyGo 0.32

Changes include:

  1. Go Toolchain Update: The Go toolchain used for building WebAssembly modules has
    been upgraded to Go 1.22.5. This ensures that the compiled WASM modules take advantage
    of the latest compiler optimizations and language improvements.

  2. TinyGo Integration: TinyGo support has been updated to version 0.32, which
    introduces new optimizations and potentially new APIs for WebAssembly development.
    This allows for smaller binary sizes and potentially better performance in
    resource-constrained environments.

  3. Documentation Updates: The documentation for filter_wasm_go has been updated to
    reflect the new supported versions of Go and TinyGo, as well as any changes in
    build/deployment instructions.

  4. Dependency Management: Any third-party dependencies required for building or
    testing the WebAssembly filters have been updated to be compatible with the new
    versions of Go and TinyGo.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Copy link
Contributor

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that this change should be correct during confirmation of another issue.
The current tinygo did drop the -wasm-abi option. Thanks for confirming and upgrading tinygo using example.

@cosmo0920 cosmo0920 added this to the Fluent Bit v3.1.7 milestone Aug 22, 2024
@edsiper edsiper merged commit eea409c into fluent:master Aug 27, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants